Set GPUCompiler lower bound for adaptive GPU performance#473
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
Set GPUCompiler lower bound for adaptive GPU performance#473ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
3e95506 to
a9a39f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #434.
Summary
GPUCompileras a weak dependency.GPUCompilercompat floor to1.13.2.Root cause
The adaptive Lorenz regression tracks to a GPUCompiler/NVPTX codegen cliff in GPUCompiler
1.13.1and earlier. On the stock DiffEqGPU adaptive kernel body, GPUCompiler1.13.1produced the slow path at about211.8 ms; GPUCompiler1.13.2restored the expected path at about47.9 ms.The minimal compiler-pipeline difference I isolated is the
EarlyCSEPass()inserted afterSROAPass()in GPUCompiler's early simplification pipeline. Rebuilding GPUCompiler1.13.1with only that pass restored the adaptive benchmark to about47.8 ms, matching1.13.2+behavior.This package-level fix avoids known-bad compiler versions without adding GPUCompiler as a hard dependency for non-GPU installs.
Validation
git diff origin/master --statProject.toml | 2 ++git diff --checkJULIA_DEPOT_PATH=$PWD/dev/julia_depot: julia --project=test -e 'using Pkg; Pkg.resolve(); Pkg.status(["CUDA", "GPUCompiler"]; mode = Pkg.PKGMODE_MANIFEST)'CUDA v6.2.0GPUCompiler v1.22.7JULIA_DEPOT_PATH=$PWD/dev/julia_depot: GROUP=QA julia --project=test test/runtests.jlSafeTestsetsis unavailable after activatingtest/qaNotes
The GPU benchmark investigation was performed on
demeter2with the issue reproducer. Other candidates checked and ruled out included extra rejected steps, saving/output, tstops, DAE init/finalization, workgroup size, Julia version, fixed-step Tsit5, raw SVector Lorenz loops, and the stock DiffEqGPUstep!body itself.